[iOS] Fix outputs when iOS artifacts generator is run from Xcode script phase #54066
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Expo
kitten
force-pushed
the
@kitten/fix/codegen-run-in-xcode
branch
2 times, most recently
from
87f82c4 to
79a1ca4
Compare
kitten
force-pushed
the
@kitten/fix/codegen-run-in-xcode
branch
from
79a1ca4 to
d08506e
Compare
…pt_phases.sh Avoid ending up in in derive data output folder to be able to discover `autolinking.json` generated in Cocoapods step in all cases, regardless of if the script checks `RCT_SCRIPT_OUTPUT_DIR` itself.
kitten
force-pushed
the
@kitten/fix/codegen-run-in-xcode
branch
from
d08506e to
b464256
Compare
chrfalch
added a commit
to expo/expo
that referenced
this pull request
Oct 6, 2025
An earlier change (0.79 and onwards, I believe?) runs the iOS artifacts code generator script in Xcode as well as from Cocoapods. This duplication runs it twice, but the second step isn't able to load the new autolinking.json correctly; See: #53503 This has been fixed upstream here: facebook/react-native#54066 Untill this one is merged, released and available to Expo, we need a workaround. Added build phase script for a workaround to autolinking-generated react-native-config output not being used in ReactCodegen script phase due to temp output directory.
2 tasks
|
The change is much earlier. We always run codegen in xcode. This allows users to write native modules and native components locally in their app, without having to reinstall cocopods everytime they change the specs of those custom modules/components. |
cipolleschi
requested changes
Oct 6, 2025
packages/react-native/scripts/react_native_pods_utils/script_phases.sh
Outdated
Show resolved
Hide resolved
| moveOutputs | ||
| describe "Generating codegen artifacts" | ||
| pushd "$RCT_SCRIPT_RN_DIR" >/dev/null || exit 1 | ||
| "$NODE_BINARY" "scripts/generate-codegen-artifacts.js" --path "$RCT_SCRIPT_APP_PATH" --outputPath "$RCT_SCRIPT_OUTPUT_DIR" --targetPlatform "ios" |
There was a problem hiding this comment.
The value of RCT_SCRIPT_OUTPUT_DIR is always RCT_SCRIPT_POD_INSTALLATION_ROOT, which is set to be
pushd "$PODS_ROOT/../" > /dev/null
RCT_SCRIPT_POD_INSTALLATION_ROOT=$(pwd)
So it will always be Pods/.., which is where we want codegen to be generated.
Just adding the comment for the future.
packages/react-native/scripts/codegen/generate-artifacts-executor/utils.js
Show resolved
Hide resolved
kitten
force-pushed
the
@kitten/fix/codegen-run-in-xcode
branch
from
90bc77f to
bb178a4
Compare
kitten
force-pushed
the
@kitten/fix/codegen-run-in-xcode
branch
from
bb178a4 to
d5955f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
An earlier change (0.79 and onwards, I believe?) runs the iOS artifacts code generator script in Xcode as well as from Cocoapods. This duplication runs it twice, but the second step isn't able to load the new
autolinking.jsoncorrectly; See: #53503This PR "double" fixes this by:
script_phases.sh) where it's called by Xcode, rather than a temporary directory$RCT_SCRIPT_OUTPUT_DIRif it's set as an environment variable in the artifacts generator (which it is byscript_phases.sh)While this is technically redundant, future changes here make this feel like a safer option, since both conventions overlap in these two places, and the double fix may prevent a regression here in the shortterm and convey what this path is supposed to be in both places.
Changelog:
[IOS] [FIXED] - Fix autolinking-generated react-native-config output not being used in ReactCodegen script phase due to temp output directory
Test Plan:
$RCT_SCRIPT_OUTPUT_DIRenv var for findingbuild/generated/autolinking/autolinking.json$RCT_SCRIPT_OUTPUT_DIRas output inwithCodegenDiscoveryinreact_native_pods_utils/script_phases.sh(which is called by Xcode rather than Cocoapods to invoke the artifacts generator) since the temporary output directory isn't necessary