[iOS] Fix outputs when iOS artifacts generator is run from Xcode script phase

packages/react-native/scripts/codegen/generate-artifacts-executor/utils.js

@@ -100,20 +100,28 @@ function cleanupEmptyFilesAndFolders(filepath /*: string */) {
 function readGeneratedAutolinkingOutput(
   baseOutputPath /*: string */,
 ) /*: $FlowFixMe */ {
-  // NOTE: Generated by scripts/cocoapods/autolinking.rb in list_native_modules (called by use_native_modules)
-  const autolinkingGeneratedPath = path.resolve(
+  const outputPathCandidates = [
+    // The `outputDir` may not be set correctly if it's set to the a temporary output directory
+    process.env.RCT_SCRIPT_OUTPUT_DIR,
+    // NOTE: Generated by scripts/cocoapods/autolinking.rb in list_native_modules (called by use_native_modules)
     baseOutputPath,
-    'build/generated/autolinking/autolinking.json',
-  );
-  if (fs.existsSync(autolinkingGeneratedPath)) {
-    // $FlowFixMe[unsupported-syntax]
-    return require(autolinkingGeneratedPath);
-  } else {
-    codegenLog(
-      `Could not find generated autolinking output at: ${autolinkingGeneratedPath}`,
-    );
-    return null;
+  ];
+  for (const outputPathCandidate of outputPathCandidates) {
+    if (outputPathCandidate != null && outputPathCandidate.length > 0) {
+      const autolinkingGeneratedPath = path.resolve(
+        outputPathCandidate,
+        'build/generated/autolinking/autolinking.json',
+      );
+      if (fs.existsSync(autolinkingGeneratedPath)) {
+        // $FlowFixMe[unsupported-syntax]
+        return require(autolinkingGeneratedPath);
+      }
+      codegenLog(
+        `Could not find generated autolinking output at: ${autolinkingGeneratedPath}`,
+      );
+    }
   }
+  return null;
 }
 
 function readReactNativeConfig(

packages/react-native/scripts/react_native_pods_utils/script_phases.sh

@@ -93,13 +93,6 @@ generateCodegenArtifactsFromSchema () {
     popd >/dev/null || exit 1
 }
 
-generateArtifacts () {
-    describe "Generating codegen artifacts"
-    pushd "$RCT_SCRIPT_RN_DIR" >/dev/null || exit 1
-        "$NODE_BINARY" "scripts/generate-codegen-artifacts.js" --path "$RCT_SCRIPT_APP_PATH" --outputPath "$TEMP_OUTPUT_DIR" --targetPlatform "ios"
-    popd >/dev/null || exit 1
-}
-
 moveOutputs () {
     mkdir -p "$RCT_SCRIPT_OUTPUT_DIR"
 
@@ -110,22 +103,21 @@ moveOutputs () {
 }
 
 withCodegenDiscovery () {
-    setup_dirs
-    find_node
-    find_codegen
-    generateArtifacts
-    moveOutputs
+    describe "Generating codegen artifacts"
+    pushd "$RCT_SCRIPT_RN_DIR" >/dev/null || exit 1
+        "$NODE_BINARY" "scripts/generate-codegen-artifacts.js" --path "$RCT_SCRIPT_APP_PATH" --outputPath "$RCT_SCRIPT_OUTPUT_DIR" --targetPlatform "ios"
+    popd >/dev/null || exit 1
 }
 
 noCodegenDiscovery () {
     setup_dirs
-    find_node
-    find_codegen
     generateCodegenSchemaFromJavaScript
     generateCodegenArtifactsFromSchema
     moveOutputs
 }
 
+find_node
+find_codegen
 if [ "$RCT_SCRIPT_TYPE" = "withCodegenDiscovery" ]; then
     withCodegenDiscovery "$@"
 else