Extract cloneProp in animation backend #54606
Closed
+36
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@bartlomiejbloniarz has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86414627. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
Summary: This diff extracts the `cloneProp` helper from `AnimationBackend::cloneProps` so the logic can be reused # Changelog [General] [Changed] - Extracted `cloneProp` from `AnimationBackend.cpp` to `AnimatedProps.h` Differential Revision: D86414627
Summary: This diff extracts the `cloneProp` helper from `AnimationBackend::cloneProps` so the logic can be reused # Changelog [General] [Changed] - Extracted `cloneProp` from `AnimationBackend.cpp` to `AnimatedProps.h` Reviewed By: sammy-SC Differential Revision: D86414627
facebook-github-bot
force-pushed
the
export-D86414627
branch
from
f730532 to
228af03
Compare
|
This pull request has been merged in 33f783a. |
Collaborator
|
This pull request was successfully merged by Bartlomiej Bloniarz in 33f783a When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff extracts the
cloneProphelper fromAnimationBackend::clonePropsso the logic can be reusedChangelog
[General] [Changed] - Extracted
clonePropfromAnimationBackend.cpptoAnimatedProps.hDifferential Revision: D86414627