Skip to content

Extract cloneProp in animation backend #54606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+36 −28
Closed

Extract cloneProp in animation backend #54606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedProps.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,43 @@ T get(const std::unique_ptr<AnimatedPropBase> &animatedProp)
return static_cast<AnimatedProp<T> *>(animatedProp.get())->value;
}

template <typename T>
T get(const AnimatedPropBase &animatedProp)
{
return static_cast<const AnimatedProp<T> &>(animatedProp).value;
}

struct AnimatedProps {
std::vector<std::unique_ptr<AnimatedPropBase>> props;
std::unique_ptr<RawProps> rawProps;
};

inline void cloneProp(BaseViewProps &viewProps, const AnimatedPropBase &animatedProp)
{
switch (animatedProp.propName) {
case OPACITY:
viewProps.opacity = get<Float>(animatedProp);
break;

case WIDTH:
viewProps.yogaStyle.setDimension(yoga::Dimension::Width, get<yoga::Style::SizeLength>(animatedProp));
break;

case HEIGHT:
viewProps.yogaStyle.setDimension(yoga::Dimension::Height, get<yoga::Style::SizeLength>(animatedProp));
break;

case BORDER_RADII:
viewProps.borderRadii = get<CascadedBorderRadii>(animatedProp);
break;

case FLEX:
viewProps.yogaStyle.setFlex(get<yoga::FloatOptional>(animatedProp));
break;

case TRANSFORM:
viewProps.transform = get<Transform>(animatedProp);
break;
}
}
} // namespace facebook::react
29 changes: 1 addition & 28 deletions packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,34 +41,7 @@ static inline Props::Shared cloneProps(
auto viewProps = std::const_pointer_cast<BaseViewProps>(
std::static_pointer_cast<const BaseViewProps>(newProps));
for (auto& animatedProp : animatedProps.props) {
switch (animatedProp->propName) {
case OPACITY:
viewProps->opacity = get<Float>(animatedProp);
break;

case WIDTH:
viewProps->yogaStyle.setDimension(
yoga::Dimension::Width, get<yoga::Style::SizeLength>(animatedProp));
break;

case HEIGHT:
viewProps->yogaStyle.setDimension(
yoga::Dimension::Height,
get<yoga::Style::SizeLength>(animatedProp));
break;

case BORDER_RADII:
viewProps->borderRadii = get<CascadedBorderRadii>(animatedProp);
break;

case FLEX:
viewProps->yogaStyle.setFlex(get<yoga::FloatOptional>(animatedProp));
break;

case TRANSFORM:
viewProps->transform = get<Transform>(animatedProp);
break;
}
cloneProp(*viewProps, *animatedProp);
}
return newProps;
}
Expand Down
Loading