Skip to content

Conversation

@mlisikbf
Copy link

@mlisikbf mlisikbf commented Jan 7, 2026

Summary:

Fixes #55074 by reverting to UIAlertActionStyleDefault for iPad action sheet and iOS26 action sheet (meaning app was built with SDK26, is running on iOS26, and without UIDesignRequiresCompatibility enabled).

Changelog:

[IOS] [FIXED] - ActionSheet: prevent cancelButtonIndex from causing buttons to disappear when using popover action sheet

Test Plan:

Used https://github.com/mlisikbf/MobileTest_ActionSheet/tree/test-patch as a starting point. It has the change applied via patch-package, and uses action sheets with/without an anchor, and with/without cancelButtonIndex. Scenarios to test:

built with SDK26, running iOS26
Simulator.Screen.Recording.-.iPad.A16.-.2026-01-07.at.13.58.01.mov
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-01-07.at.14.02.45.mov
built with SDK26, running iOS18
Simulator.Screen.Recording.-.iPad.mini.6th.generation.-.2026-01-07.at.14.25.21.mov
Simulator.Screen.Recording.-.iPhone.16.iOS.18.-.2026-01-07.at.14.25.09.mov
built with SDK 18, running iOS26

(cannot install older build tools atm, but this will be the same case as UIDesignRequiresCompatibility below)

built with SDK26, running iOS26 with `UIDesignRequiresCompatibility`
Simulator.Screen.Recording.-.iPad.A16.-.2026-01-07.at.14.51.33.mov
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-01-07.at.14.53.47.mov

@meta-cla
Copy link

meta-cla bot commented Jan 7, 2026

Hi @mlisikbf!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@mlisikbf mlisikbf force-pushed the fix-cancel-button-missing-in-action-sheet-ios-26 branch from 1938640 to ca7e043 Compare January 7, 2026 14:06
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 7, 2026
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jan 7, 2026
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this issue!

@meta-codesync
Copy link

meta-codesync bot commented Jan 7, 2026

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D90257007.

@mlisikbf
Copy link
Author

mlisikbf commented Jan 9, 2026

For whatever reason, I am unable to reproduce today with the reproducer and a new, fresh project (both on latest RN). Will convert this to draft and continue testing.

@mlisikbf mlisikbf marked this pull request as draft January 9, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iOS26] [SDK26] with ActionSheetIOS, specifying cancelButtonIndex causes the button at that index to disappear

3 participants