Skip to content

fix(ios): missing cancel button when using popover action sheet (running on iPad or with SDK26 on iPhone) #55077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mlisikbf wants to merge 2 commits into
base: main
Choose a base branch
from
+23 −1
Draft

fix(ios): missing cancel button when using popover action sheet (running on iPad or with SDK26 on iPhone) #55077

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b24809
skips UIAlertActionStyleCancel for ActionSheedIOS actions when using …
mlisikbf Jan 7, 2026
ca7e043
covers iPad, extracts static inline util
mlisikbf Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion packages/react-native/React/CoreModules/RCTActionSheetManager.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,28 @@

using namespace facebook::react;

// With popover action sheet, cancel button disappears with style = UIAlertActionStyleCancel
// Reverting to default style when:
// - building with SDK 26+ AND running on iOS 26+ AND UIDesignRequiresCompatibility is disabled
// - running on iPad
static inline UIAlertActionStyle RCTActionStyleForCancelButton(void)
{
if (UIDevice.currentDevice.userInterfaceIdiom == UIUserInterfaceIdiomPad) {
return UIAlertActionStyleDefault;
}

#if __IPHONE_OS_VERSION_MAX_ALLOWED >= 260000
if (@available(iOS 26, *)) {
if ([[[NSBundle mainBundle] objectForInfoDictionaryKey:@"UIDesignRequiresCompatibility"] boolValue]) {
return UIAlertActionStyleCancel;
}

return UIAlertActionStyleDefault;
}
#endif
return UIAlertActionStyleCancel;
}

@interface RCTActionSheetManager () <NativeActionSheetManagerSpec>

@property (nonatomic, strong) NSMutableArray<UIAlertController *> *alertControllers;
Expand Down Expand Up @@ -154,7 +176,7 @@ - (void)presentViewController:(UIViewController *)alertController
if ([destructiveButtonIndices containsObject:@(index)]) {
style = UIAlertActionStyleDestructive;
} else if (index == cancelButtonIndex) {
style = UIAlertActionStyleCancel;
style = RCTActionStyleForCancelButton();
isCancelButtonIndex = true;
}

Expand Down
Loading