Fix set-version script not updating dependencies under private/ #55083
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: D86534510 broke our release workflow, as the intentionally narrowed package set for `set-version` unintentionally meant that `dependencies`/`devDependencies` were no longer completely applied — breaking `yarn` install. Fix and add clarification comments. Changelog: [Internal] Differential Revision: D90268470
meta-cla
bot
added
the
CLA Signed
Collaborator
|
This pull request was successfully merged by @huntie in 24c126d When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 24c126d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
D86534510 broke our release workflow, as the intentionally narrowed package set for
set-versionunintentionally meant thatdependencies/devDependencieswere no longer completely applied — breakingyarninstall.Fix and add clarification comments.
Changelog: [Internal]
Differential Revision: D90268470