Skip to content

Fix set-version script not updating dependencies under private/ #55083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huntie wants to merge 1 commit into from
+13 −3
Closed

Fix set-version script not updating dependencies under private/ #55083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions scripts/releases/set-version.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,22 +71,32 @@ async function setVersion(
version /*: string */,
skipReactNativeVersion /*: boolean */ = false,
) /*: Promise<void> */ {
const packages = await getPackages({
// Packages to set the new versions of. This excludes packages under
// private/, which are not versioned.
const packagesToVersion = await getPackages({
includeReactNative: true,
forceIncludeRNTester: true,
});
const newPackageVersions = Object.fromEntries(
Object.keys(packages).map(packageName => [
Object.keys(packagesToVersion).map(packageName => [
packageName,
packageName === 'react-native' && skipReactNativeVersion
? '1000.0.0'
: version,
]),
);

// Packages to apply updated versions in (dependencies/devDependencies). This
// is all packages and the workspace root.
const packagesToUpdate = [
await getWorkspaceRoot(),
...Object.values(packages),
...Object.values(
await getPackages({
includeReactNative: true,
includePrivate: true,
forceIncludeRNTester: true,
}),
),
];

// Update all workspace packages
Expand Down