macOS: rewrite fs config provider using fsnotify#684
Open
lf- wants to merge 1 commit intofacebookincubator:mainfrom
Open
macOS: rewrite fs config provider using fsnotify#684lf- wants to merge 1 commit intofacebookincubator:mainfrom
lf- wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for fb-oss-glean canceled.
|
meta-cla
bot
added
the
CLA Signed
lf-
force-pushed
the
jade/push-mtkprsmzsxzu
branch
from
1e5fc92 to
7856ce3
Compare
lf-
force-pushed
the
jade/push-mtkprsmzsxzu
branch
from
7856ce3 to
76f4bff
Compare
Contributor
Author
|
Done! |
This means that we lose an hinotify dependency and replace it with fsnotify, which supports all platforms (and also can poll if needed!) and actually *uses* hinotify internally. With this change, Glean builds and has basic functionality working on my machine on macOS!!
lf-
force-pushed
the
jade/push-mtkprsmzsxzu
branch
from
76f4bff to
0b6568e
Compare
Contributor
|
@aahanaggarwal has imported this pull request. If you are a Meta employee, you can view this in D93098891. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means that we lose an hinotify dependency and replace it with fsnotify, which supports all platforms (and also can poll if needed!) and actually uses hinotify internally.
With this change, Glean builds and has basic functionality working on my machine on macOS!!