Open
Conversation
meta-cla
bot
added
the
CLA Signed
✅ Deploy Preview for fb-oss-glean canceled.
|
Contributor
|
@aahanaggarwal has imported this pull request. If you are a Meta employee, you can view this in D92956010. |
|
Basically buck run fbcode//glean/glass/test/regression:flow is ooming our conveyors. It wasn't clear how to fix it without splitting the test, or why it was broken. I'm reverting my initial revert diff and will try again, based on your observation that it is fast in the OSS CI. |
meta-codesync bot
pushed a commit
that referenced
this pull request
Feb 11, 2026
Summary: Original commit changeset: 3d64518aa5bb Original Phabricator Diff: D91738264 Simon Marlow is arguing [here](#695) that this test should be fast, and that splitting it isn't the right approach. It's only 4.5 seconds in the OSS CI so there's another issue that makes it slow with buck. Reviewed By: aahanaggarwal Differential Revision: D92957270 fbshipit-source-id: e143018535ba0ae15b07d0a564093dd2c47606e1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell it's not necessary to break up this test, mainly putting up this PR to have the conversation :)
Perhaps some issue with the Meta test framework or something? At a guess, I imagine the framework is running each of the 101 tests separately, which results in building the test DB 101 times. If that's the problem, just treat it as a single test. (I remember there was some discussion about supporting "bundled" tests or something like that which was designed for this use case, but AFAIK it was never finished).