Skip to content

fix(rpc): Fix CMake header-only library targets for velox_rpc_types and velox_rpc_client (#16748) #16748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhichenxu-meta wants to merge 1 commit into from
+5 −9
Closed

fix(rpc): Fix CMake header-only library targets for velox_rpc_types and velox_rpc_client (#16748) #16748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions velox/common/rpc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@

velox_install_library_headers()

velox_add_library(velox_rpc_types RPCTypes.h)
velox_add_library(velox_rpc_types INTERFACE RPCTypes.h)

velox_add_library(velox_rpc_client IRPCClient.h)
velox_add_library(velox_rpc_client INTERFACE IRPCClient.h)

velox_link_libraries(velox_rpc_client velox_rpc_types Folly::folly)
velox_link_libraries(velox_rpc_client INTERFACE velox_rpc_types Folly::folly)

velox_add_library(velox_mock_rpc_client clients/MockRPCClient.cpp)

Expand Down
8 changes: 2 additions & 6 deletions velox/expression/rpc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,9 @@

velox_install_library_headers()

velox_add_library(velox_async_rpc_function AsyncRPCFunction.h)
velox_add_library(velox_async_rpc_function INTERFACE AsyncRPCFunction.h)

velox_link_libraries(
velox_async_rpc_function
velox_rpc_client
velox_rpc_types
velox_core
velox_type
velox_vector
INTERFACE velox_rpc_client velox_rpc_types velox_core velox_type velox_vector
)
Loading