Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
=======================================
Coverage 64.02% 64.02%
=======================================
Files 6 6
Lines 378 378
=======================================
Hits 242 242
Misses 136 136 Continue to review full report in Codecov by Sentry.
|
emgrav
previously approved these changes
Apr 24, 2025
Contributor
|
LGTM but https://github.com/famedly/famedly-rust-utils/pull/30/files#r2058043689. If we want "stable release" we should adress those |
sirewix
approved these changes
Apr 28, 2025
tlater-famedly
added a commit
that referenced
this pull request
May 6, 2025
A half-applied suggestion from review during the release PR in #31 broke features that depend on serde.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't look too closely at the branch name.