Skip to content

Conversation

acyment
Copy link

@acyment acyment commented Jan 10, 2025

I simply migrated from npm to pnpm to benefit from increased performance. I had to add zod to package.json because of the way npm and pnpm deal with dependencies. It also made sense to add it as an explicit dependency, as it is being imported in two files in the frontend/src/routes/_layout folder (admin.tsx & items.tsx).

Cheers!

Copy link
Contributor

@wesenbergg wesenbergg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you are missing pnpm-lock.yaml file

@tiangolo
Copy link
Member

Thanks for the interest! For now, I prefer to keep the template simple with plain npm. I think it's totally fine for people and teams to adopt pnpm if preferred, but for this template I'll keep it as it is for now.

Given that, I'll close this one, but thanks for the effort! ☕

@tiangolo tiangolo closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants