Skip to content

Migrate to pnpm #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
acyment wants to merge 1 commit into from
Closed

Migrate to pnpm #1457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions frontend/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,15 @@ WORKDIR /app

COPY package*.json /app/

RUN npm install
RUN corepack enable

RUN pnpm install

COPY ./ /app/

ARG VITE_API_URL=${VITE_API_URL}

RUN npm run build
RUN pnpm run build


# Stage 1, based on Nginx, to have only the compiled app, ready for production with Nginx
Expand Down
6 changes: 4 additions & 2 deletions frontend/Dockerfile.playwright
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@ WORKDIR /app

COPY package*.json /app/

RUN npm install
RUN corepack enable

RUN npx -y playwright install --with-deps
RUN pnpm install

RUN pnpm dlx playwright install --with-deps

COPY ./ /app/

Expand Down
6 changes: 4 additions & 2 deletions frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@
"react-dom": "^18.2.0",
"react-error-boundary": "^4.0.13",
"react-hook-form": "7.49.3",
"react-icons": "5.0.1"
"react-icons": "5.0.1",
"zod": "^3.22.4"
},
"devDependencies": {
"@biomejs/biome": "1.6.1",
Expand All @@ -40,5 +41,6 @@
"dotenv": "^16.4.5",
"typescript": "^5.2.2",
"vite": "^5.0.13"
}
},
"packageManager": "[email protected]"
}
2 changes: 1 addition & 1 deletion frontend/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ export default defineConfig({

/* Run your local dev server before starting the tests */
webServer: {
command: 'npm run dev',
command: 'pnpm run dev',
url: 'http://localhost:5173',
reuseExistingServer: !process.env.CI,
},
Expand Down
4 changes: 2 additions & 2 deletions scripts/generate-client.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ python -c "import app.main; import json; print(json.dumps(app.main.app.openapi()
cd ..
mv openapi.json frontend/
cd frontend
npm run generate-client
npx biome format --write ./src/client
pnpm run generate-client
pnpm exec biome format --write ./src/client
Loading