Add Fish shell completion tests for colon options #1475
+49
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svlandeg
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the missing Fish shell completion tests that were marked as TODO in
test_completion_option_colon.py.Changes
test_completion_colon_fish_all()- Tests all completions are showntest_completion_colon_fish_partial()- Tests partial matching (e.g., "alpine" matches both variants)test_completion_colon_fish_single()- Tests single match completionTesting
All 3 new tests pass, and all 16 tests in the file pass without issues.
Fixes the TODO comment at line 219 in
tests/test_completion/test_completion_option_colon.py.