Skip to content

Add Fish shell completion tests for colon options #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mohamed-Elwasila wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Fish shell completion tests for colon options #1475

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5627f32
Add Fish shell completion tests for colon options
Mohamed-Elwasila Jan 6, 2026
d4483ae
Merge branch 'master' into add-fish-completion-tests
svlandeg Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 49 additions & 1 deletion tests/test_completion/test_completion_option_colon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,4 +216,52 @@ def test_completion_colon_pwsh_single():
assert "nvidia/cuda:10.0-devel-ubuntu18.04" not in result.stdout


# TODO: tests for complete_fish
def test_completion_colon_fish_all():
result = subprocess.run(
[sys.executable, "-m", "coverage", "run", mod.__file__, " "],
capture_output=True,
encoding="utf-8",
env={
**os.environ,
"_COLON_EXAMPLE.PY_COMPLETE": "complete_fish",
"_TYPER_COMPLETE_ARGS": "colon_example.py --name ",
"_TYPER_COMPLETE_FISH_ACTION": "get-args",
},
)
assert "alpine:hello" in result.stdout
assert "alpine:latest" in result.stdout
assert "nvidia/cuda:10.0-devel-ubuntu18.04" in result.stdout


def test_completion_colon_fish_partial():
result = subprocess.run(
[sys.executable, "-m", "coverage", "run", mod.__file__, " "],
capture_output=True,
encoding="utf-8",
env={
**os.environ,
"_COLON_EXAMPLE.PY_COMPLETE": "complete_fish",
"_TYPER_COMPLETE_ARGS": "colon_example.py --name alpine",
"_TYPER_COMPLETE_FISH_ACTION": "get-args",
},
)
assert "alpine:hello" in result.stdout
assert "alpine:latest" in result.stdout
assert "nvidia/cuda:10.0-devel-ubuntu18.04" not in result.stdout


def test_completion_colon_fish_single():
result = subprocess.run(
[sys.executable, "-m", "coverage", "run", mod.__file__, " "],
capture_output=True,
encoding="utf-8",
env={
**os.environ,
"_COLON_EXAMPLE.PY_COMPLETE": "complete_fish",
"_TYPER_COMPLETE_ARGS": "colon_example.py --name alpine:hell",
"_TYPER_COMPLETE_FISH_ACTION": "get-args",
},
)
assert "alpine:hello" in result.stdout
assert "alpine:latest" not in result.stdout
assert "nvidia/cuda:10.0-devel-ubuntu18.04" not in result.stdout