Fix test by updating console output fixture #32
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
The Codecov issue mentioned in #28 may still exist though. |
|
Hmm, still failing I see. Let me investigate some more. |
andyw8
force-pushed
the
andyw8/update-test-fixture
branch
from
ae344e8 to
ce41041
Compare
|
Ok it's passing for 3.0 at least now. What do you think about the approach of committing |
|
🤔 Actually, shouldn't the report be listing gems for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an entry to(not done since this only affects the tests)CHANGELOG.mdthat links to this PR under the "main (unreleased)" heading.Description:
When checking out the repo and testing locally I was seeing a failure. It was due to a newer
simplecov-console(v0.9.3) having an additional dependency.