-
Notifications
You must be signed in to change notification settings - Fork 4
Doc changes for the faucet 2.1 #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Rewrote the documentation on writing a plugin, @FND - also a good refresher on how we designed it 😄 |
|
@FND This includes all adjustments that we have released now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
src/static.md
Outdated
| with projects using ESM. [Please refer to faucet-pipeline-static for the new | ||
| version.](/assets) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| with projects using ESM. [Please refer to faucet-pipeline-static for the new | |
| version.](/assets) | |
| with projects using ESM. [Please refer to faucet-pipeline-assets for the new | |
| version.](/assets) |
or even
| with projects using ESM. [Please refer to faucet-pipeline-static for the new | |
| version.](/assets) | |
| with projects using ESM. Please use [faucet-pipeline-assets](/assets) instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll go with the second one 👍
src/static.md
Outdated
| }] | ||
| }; | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We keep the docs for static for now, including its hints on how to do compaction.
|
Deployed ☑️ |

compaction.
Note: I extracted the changes to building a pipeline to #150 as that belongs to the 3.x series