Skip to content

Conversation

@felbinger
Copy link
Owner

No description provided.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 4, 2025

Deploying adminguide with  Cloudflare Pages  Cloudflare Pages

Latest commit: 22a9af7
Status: ✅  Deploy successful!
Preview URL: https://a73dceee.adminguide.pages.dev
Branch Preview URL: https://remove-version.adminguide.pages.dev

View logs

@felbinger felbinger requested review from Copilot and herrluisi August 4, 2025 16:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated version attribute from all Docker Compose configuration examples in the documentation. Docker Compose no longer requires the version field in modern versions, making this cleanup necessary for maintaining up-to-date documentation.

Key changes:

  • Removed version: '3.9' (and similar) lines from all Docker Compose YAML examples
  • Added a git blame ignore configuration to exclude this formatting change from blame history

Reviewed Changes

Copilot reviewed 35 out of 38 changed files in this pull request and generated no comments.

Show a summary per file
File Description
docs/services/*.md Removed version attribute from Docker Compose examples across 31 service documentation files
docs/installation/20_traefik.md Updated Traefik installation documentation to remove version attribute
docs/31_monitoring.md Removed version attribute from monitoring setup example
docs/22_internal_networks.md Updated internal networks documentation examples
.git-blame-ignore-revs Added configuration to ignore this formatting commit in git blame

@felbinger felbinger mentioned this pull request Aug 4, 2025
Copy link
Collaborator

@herrluisi herrluisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Korrigiere den einen Grammatikfehler und schau bitte ob das mit den entfernten Leerzeichen passt. Auch bei verschiedenen Fenstergrößen

### Nextcloud
Im Falle von Nextcloud wird der `nextcloud` Container neben dem
Im Falle von Nextcloud wird der `nextcloud` Container neben dem
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wird das online richtig angezeigt? Ist zwischen dem "dem" und dem "´database´" online ein Leerzeichen bzw eine Leerzeile?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

natürlich, newline ist ja auch ein white space char (\n, \t, space)
image

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, bild zeigt falsche stelle aber richtigen Ausschnitt :D

@felbinger
Copy link
Owner Author

someone decided to dismiss my instructions to merge #120 before #121, so this pr has already processed

@felbinger felbinger closed this Aug 4, 2025
@felbinger felbinger deleted the remove-version branch August 4, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants