-
Notifications
You must be signed in to change notification settings - Fork 10
chore: docker-compose.yml remove attribute version #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying adminguide with
|
| Latest commit: |
22a9af7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a73dceee.adminguide.pages.dev |
| Branch Preview URL: | https://remove-version.adminguide.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated version attribute from all Docker Compose configuration examples in the documentation. Docker Compose no longer requires the version field in modern versions, making this cleanup necessary for maintaining up-to-date documentation.
Key changes:
- Removed
version: '3.9'(and similar) lines from all Docker Compose YAML examples - Added a git blame ignore configuration to exclude this formatting change from blame history
Reviewed Changes
Copilot reviewed 35 out of 38 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docs/services/*.md | Removed version attribute from Docker Compose examples across 31 service documentation files |
| docs/installation/20_traefik.md | Updated Traefik installation documentation to remove version attribute |
| docs/31_monitoring.md | Removed version attribute from monitoring setup example |
| docs/22_internal_networks.md | Updated internal networks documentation examples |
| .git-blame-ignore-revs | Added configuration to ignore this formatting commit in git blame |
herrluisi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Korrigiere den einen Grammatikfehler und schau bitte ob das mit den entfernten Leerzeichen passt. Auch bei verschiedenen Fenstergrößen
| ### Nextcloud | ||
| Im Falle von Nextcloud wird der `nextcloud` Container neben dem | ||
| Im Falle von Nextcloud wird der `nextcloud` Container neben dem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wird das online richtig angezeigt? Ist zwischen dem "dem" und dem "´database´" online ein Leerzeichen bzw eine Leerzeile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm, bild zeigt falsche stelle aber richtigen Ausschnitt :D

No description provided.