Improve #121
Merged
Improve #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying adminguide with
|
| Latest commit: |
0f7d389
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e66f242f.adminguide.pages.dev |
| Branch Preview URL: | https://fix-typo.adminguide.pages.dev |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR performs maintenance tasks to improve the documentation and configuration, including fixing a typo, updating the admin group ID, and removing an outdated script.
- Fixed grammar and formatting in the Docker installation documentation
- Updated admin group ID from 997 to 1100 in postinstall.sh
- Removed deprecated Docker Compose version declarations from all service documentation files
- Removed the serve.sh script and updated README accordingly
Reviewed Changes
Copilot reviewed 39 out of 42 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| serve.sh | Completely removed the Docker-based development server script |
| postinstall.sh | Updated admin group ID configuration value |
| docs/services/*.md | Removed deprecated version: '3.9' declarations from Docker Compose examples |
| docs/installation/*.md | Removed version declarations and fixed documentation formatting |
| docs/*.md | Removed version declarations from monitoring and networking examples |
| README.md | Updated contribution instructions to remove references to serve.sh |
| .git-blame-ignore-revs | Added configuration to ignore formatting commits in git blame |
herrluisi
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #120 first