fix(typescript): Update WebSocket allow-multiple query params to include undefined in type #11064
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refs: Follow-up to #10966
Updates WebSocket
ConnectArgsinterface to conditionally includeundefinedin the union type forallow-multiple: truequery parameters based on whether the parameter is optional:foo: T | T[]foo?: T | T[] | undefinedLink to Devin run: https://app.devin.ai/sessions/3df4d8e6eeef4b0bb25291da9228d746
Requested by: [email protected] (@tjb9dc)
Changes Made
GeneratedDefaultWebsocketImplementation.tsto conditionally addundefinedto the union type for allow-multiple query parameters only whencontext.type.isOptional(queryParameter.valueType)is trueUpdates Since Last Revision
Based on reviewer feedback, changed from always adding
undefinedto only adding it when the query parameter's value type is optional.Testing
pnpm run check)Human Review Checklist
undefinedwhen optional) is the intended behaviorversions.ymlsaysT | T[] | undefinedunconditionally - may want to update it to reflect the conditional behaviorGeneratedRequestWrapperImpl.ts(lines 222-227) which usesT | T[]without explicitundefined- is this intentional divergence?