Skip to content

fix(typescript): Update WebSocket allow-multiple query params to include undefined in type #11064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tjb9dc wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(typescript): Update WebSocket allow-multiple query params to include undefined in type #11064

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8aae4b
fix(typescript): Update WebSocket allow-multiple query params to incl…
devin-ai-integration[bot] Dec 5, 2025
750bac4
fix(typescript): Only add undefined to allow-multiple union when type…
devin-ai-integration[bot] Dec 5, 2025
106bf93
Merge branch 'main' into devin/1764965144-websocket-allow-multiple-un…
tjb9dc Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...cript/sdk/client-class-generator/src/websocket/GeneratedDefaultWebsocketImplementation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,8 @@ export class GeneratedDefaultWebsocketImplementation implements GeneratedWebsock
const typeNode = queryParameter.allowMultiple
? ts.factory.createUnionTypeNode([
type.typeNodeWithoutUndefined,
ts.factory.createArrayTypeNode(type.typeNodeWithoutUndefined)
ts.factory.createArrayTypeNode(type.typeNodeWithoutUndefined),
ts.factory.createKeywordTypeNode(ts.SyntaxKind.UndefinedKeyword)
Copy link
Collaborator Author

@tjb9dc tjb9dc Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

um I guess this works? Should we instead be keying off of whether this allows undefined?

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point—updated to only include undefined in the union when the query parameter's value type is optional per context.type.isOptional(...). This gives us:

  • Non-optional, allow-multiple: foo: T | T[]
  • Optional, allow-multiple: foo?: T | T[] | undefined

])
: type.typeNodeWithoutUndefined;
return {
Expand Down
8 changes: 8 additions & 0 deletions generators/typescript/sdk/versions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
# yaml-language-server: $schema=../../../fern-versions-yml.schema.json
- version: 3.35.10
changelogEntry:
- summary: |
Update WebSocket `ConnectArgs` interface to type `allow-multiple: true` query parameters as `T | T[] | undefined` instead of `T | T[]` for consistency.
type: fix
createdAt: "2025-12-05"
irVersion: 62

- version: 3.35.9
changelogEntry:
- summary: |
Expand Down
Loading