feat(go): add OAuth client credentials support with automatic token refresh #11106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efresh Co-Authored-By: [email protected] <[email protected]>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
tjb9dc
commented
Dec 9, 2025
| arguments_: [ | ||
| go.TypeInstantiation.string(values.clientId), | ||
| go.TypeInstantiation.string(values.clientSecret), | ||
| go.codeblock("nil") // refreshFunc will be set by the SDK internally |
Collaborator
Author
There was a problem hiding this comment.
This doesn't seem great for users
…redentials API Address PR feedback to improve the user-facing API for OAuth client credentials: - Replace WithOAuthTokenProvider(core.NewOAuthTokenProvider(..., nil)) with simpler WithClientCredentials(clientID, clientSecret) - Store ClientID and ClientSecret in RequestOptions with internal OAuthTokenProvider field - Update EndpointSnippetGenerator to emit the new simpler API - Hide internal OAuthTokenProvider details from users This matches the Python/TypeScript pattern where users just provide credentials at construction time. Co-Authored-By: [email protected] <[email protected]>
- Add OAuthClientCredentialsConfig struct to hold OAuth configuration - Add computeOAuthClientCredentialsConfig function to extract OAuth config from IR - Update WriteClient to accept OAuth config and generate token provider initialization - Update dynamic snippets to use WithClientCredentials instead of WithOAuthTokenProvider - The SDK now automatically creates a default refreshFunc from the OAuth configuration Co-Authored-By: [email protected] <[email protected]>
Collaborator
|
closing as we cooked Devin on this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refs: Requested by @tjb9dc via Slack
Implements OAuth client credentials authentication in the Go SDK generator with automatic token refresh support, addressing the TODO at
EndpointSnippetGenerator.ts#L335-L337.Link to Devin run: https://app.devin.ai/sessions/cbaf1544965b49c2a2eef83a22b1b199
Changes Made
OAuthTokenProviderincore/oauth.gothat manages OAuth tokens with:sync.MutexWriteRequestOptionsDefinitionto addClientID,ClientSecret, and internalOAuthTokenProviderfields toRequestOptionsClientCredentialsOptionstruct andWithClientCredentials(clientID, clientSecret)option function for a cleaner user-facing APIcomputeOAuthClientCredentialsConfigfunction to extract OAuth configuration from IR auth-schemesEndpointSnippetGenerator.tsto generateWithClientCredentialsconstructor arguments instead of warningUpdates Since Last Revision
Addressed PR feedback to auto-generate OAuth token refresh from auth-schemes config:
OAuthClientCredentialsConfigstruct to hold OAuth endpoint configuration extracted from IRcomputeOAuthClientCredentialsConfigfunction that extracts token endpoint, request/response field names from IRWriteClientto accept OAuth config and generate token provider initialization codeoauth-client-credentials-defaultnow useWithClientCredentials(clientID, clientSecret)instead ofWithOAuthTokenProviderTesting
oauth-client-credentials-defaultfixtureoauth-client-credentials-environment-variablesfixturepnpm run check)Human Review Checklist
oauth-client-credentials-environment-variablesstill showsWithOAuthTokenProviderin dynamic snippets whileoauth-client-credentials-defaultusesWithClientCredentials- verify this is expected or needs fixingcomputeOAuthClientCredentialsConfighas many early return points that returnnil- verify the function correctly extracts config for all OAuth fixturesGetToken()reads fields without lock - verify the double-check pattern is sufficientExpiresIn< 120 seconds, expiry time could be in the past immediately