-
Notifications
You must be signed in to change notification settings - Fork 271
feat(go): add OAuth client credentials support with automatic token refresh #11106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
5a03002
feat(go): add OAuth client credentials support with automatic token r…
devin-ai-integration[bot] f4c2db7
refactor(go): replace WithOAuthTokenProvider with simpler WithClientC…
devin-ai-integration[bot] 6d5adb4
feat(go): auto-generate OAuth token refresh from auth-schemes config
devin-ai-integration[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| package core | ||
|
|
||
| import ( | ||
| "context" | ||
| "sync" | ||
| "time" | ||
| ) | ||
|
|
||
| const ( | ||
| // expiryBufferMinutes is the buffer time before token expiry to trigger a refresh. | ||
| expiryBufferMinutes = 2 | ||
| ) | ||
|
|
||
| // OAuthTokenProvider manages OAuth tokens with automatic refresh. | ||
| type OAuthTokenProvider struct { | ||
| clientID string | ||
| clientSecret string | ||
| accessToken string | ||
| expiresAt time.Time | ||
| refreshFunc func(ctx context.Context, clientID, clientSecret string) (*OAuthTokenResponse, error) | ||
| mu sync.Mutex | ||
| } | ||
|
|
||
| // OAuthTokenResponse represents the response from an OAuth token endpoint. | ||
| type OAuthTokenResponse struct { | ||
| AccessToken string | ||
| ExpiresIn *int // seconds until expiry (optional) | ||
| } | ||
|
|
||
| // NewOAuthTokenProvider creates a new OAuthTokenProvider. | ||
| func NewOAuthTokenProvider( | ||
| clientID string, | ||
| clientSecret string, | ||
| refreshFunc func(ctx context.Context, clientID, clientSecret string) (*OAuthTokenResponse, error), | ||
| ) *OAuthTokenProvider { | ||
| return &OAuthTokenProvider{ | ||
| clientID: clientID, | ||
| clientSecret: clientSecret, | ||
| refreshFunc: refreshFunc, | ||
| } | ||
| } | ||
|
|
||
| // GetToken returns a valid access token, refreshing if necessary. | ||
| func (o *OAuthTokenProvider) GetToken(ctx context.Context) (string, error) { | ||
| // Fast path: check if token is still valid without acquiring lock | ||
| if o.accessToken != "" && (o.expiresAt.IsZero() || time.Now().Before(o.expiresAt)) { | ||
| return o.accessToken, nil | ||
| } | ||
|
|
||
| o.mu.Lock() | ||
| defer o.mu.Unlock() | ||
|
|
||
| // Double-check after acquiring lock | ||
| if o.accessToken != "" && (o.expiresAt.IsZero() || time.Now().Before(o.expiresAt)) { | ||
| return o.accessToken, nil | ||
| } | ||
|
|
||
| return o.refresh(ctx) | ||
| } | ||
|
|
||
| // refresh fetches a new token from the OAuth endpoint. | ||
| func (o *OAuthTokenProvider) refresh(ctx context.Context) (string, error) { | ||
| response, err := o.refreshFunc(ctx, o.clientID, o.clientSecret) | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
|
|
||
| o.accessToken = response.AccessToken | ||
| if response.ExpiresIn != nil { | ||
| // Set expiry time with buffer | ||
| o.expiresAt = time.Now().Add(time.Duration(*response.ExpiresIn)*time.Second - expiryBufferMinutes*time.Minute) | ||
| } else { | ||
| // No expiry info, token is valid indefinitely | ||
| o.expiresAt = time.Time{} | ||
| } | ||
|
|
||
| return o.accessToken, nil | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem great for users