fix(python): File upload conditional using wire_value instead of parameter name #11117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🌱 Seed Test SelectorSelect languages to run seed tests for:
How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR. |
The generated code was checking `if LogoFile is not None` instead of `if logo_file is not None`, causing mypy "name not defined" errors when the API wire name differed from the Python snake_case parameter name. Changed to use `key.name.snake_case.safe_name` (the parameter name) instead of `key.wire_value` (the API field name) in the conditional. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
tjb9dc
force-pushed
the
fix-mypy-file-upload-conditional
branch
from
104dafc to
718021f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated code was checking
if LogoFile is not Noneinstead ofif logo_file is not None, causing mypy "name not defined" errors when the API wire name differed from the Python snake_case parameter name.Changed to use
key.name.snake_case.safe_name(the parameter name) instead ofkey.wire_value(the API field name) in the conditional.🤖 Generated with Claude Code