Skip to content

fix(python): File upload conditional using wire_value instead of parameter name #11117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjb9dc merged 2 commits into from
Dec 11, 2025
+10 −1
Merged

fix(python): File upload conditional using wire_value instead of parameter name #11117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
718021f
Fix file upload conditional using wire_value instead of parameter name
tjb9dc Dec 9, 2025
db25f0f
Merge branch 'main' into fix-mypy-file-upload-conditional
tjb9dc Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions generators/python/sdk/versions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# yaml-language-server: $schema=../../../fern-versions-yml.schema.json
# For unreleased changes, use unreleased.yml
- version: 4.45.5
changelogEntry:
- summary: |
Fix file upload conditional check using wire_value instead of snake_case parameter name,
which caused mypy "name not defined" errors when the API field name differed from the
Python parameter name (e.g., `MyFile` vs `my_file`).
type: fix
createdAt: "2025-12-11"
irVersion: 61

- version: 4.45.4
changelogEntry:
Expand Down
2 changes: 1 addition & 1 deletion ...ators/sdk/client_generator/request_body_parameters/file_upload_request_body_parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ def write_file_property(writer: AST.NodeWriter, file_property: ir_types.FileProp
write_file_property(writer, property_as_union.value)
writer.write("} ")
writer.write_line(
f"if {property_as_union.value.get_as_union().key.wire_value} is not None "
f"if {self._get_file_property_name(property_as_union.value)} is not None "
)
writer.write_line("else {}")
writer.write_line("),")
Expand Down
Loading