Refactoring for interface discontinuities#944
Closed
RemDelaporteMathurin wants to merge 11 commits intofestim-dev:fenicsxfrom
Closed
Refactoring for interface discontinuities#944RemDelaporteMathurin wants to merge 11 commits intofestim-dev:fenicsxfrom
RemDelaporteMathurin wants to merge 11 commits intofestim-dev:fenicsxfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #944 +/- ##
===========================================
- Coverage 96.02% 96.00% -0.02%
===========================================
Files 45 44 -1
Lines 2439 2402 -37
===========================================
- Hits 2342 2306 -36
+ Misses 97 96 -1 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
Making use of FEniCS/dolfinx#3450 we should be able to simplify the form creation using |
Collaborator
Author
|
Closing in favour of #963 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...