fix: Prevent concurrent FileUpload init() calls#19197
Merged
danharrin merged 2 commits intofilamentphp:4.xfrom Feb 4, 2026
Merged
fix: Prevent concurrent FileUpload init() calls#19197danharrin merged 2 commits intofilamentphp:4.xfrom
init() calls#19197danharrin merged 2 commits intofilamentphp:4.xfrom
Conversation
danharrin
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#19154 introduced a ResizeObserver to handle visibility changes, but since init() is async, the observer can fire during await this.getFiles() and trigger a second init() before the first completes. This race condition corrupts FilePond's internal state, causing a console error (though the component still works).
Added an isInitializing flag to guard against concurrent init() calls.
Visual changes
before
before.mov
after
after.mov
Functional changes
composer cscommand.