Skip to content

fix: Prevent concurrent FileUpload init() calls #19197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danharrin merged 2 commits into from
Feb 4, 2026
+10 −2
Merged

fix: Prevent concurrent FileUpload init() calls #19197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e86045
fix: Prevent concurrent FileUpload `init()` calls
People-Sea Feb 4, 2026
17214bf
fix: Reset isInitializing flag after FileUpload `init()` completes
People-Sea Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/forms/dist/components/file-upload.js
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 9 additions & 1 deletion packages/forms/resources/js/components/file-upload.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,15 @@ export default function fileUploadFormComponent({

visibilityObserver: null,

isInitializing: false,

async init() {
if (this.pond) {
if (this.pond || this.isInitializing) {
return
}

this.isInitializing = true

// https://github.com/filamentphp/filament/issues/15394
// https://github.com/filamentphp/filament/issues/16253
if (!this.visibilityObserver) {
Expand Down Expand Up @@ -138,6 +142,8 @@ export default function fileUploadFormComponent({
getComputedStyle(this.$el).visibility === 'hidden'

if (isHidden) {
this.isInitializing = false

return
}

Expand Down Expand Up @@ -423,6 +429,8 @@ export default function fileUploadFormComponent({
this.checkImageAspectRatio(fileItem.file)
})
}

this.isInitializing = false
},

destroy() {
Expand Down
Loading