Skip to content

Conversation

@yaira2
Copy link
Member

@yaira2 yaira2 commented Jul 29, 2025

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files, confirmed that:
    • Open in Terminal is displayed in the Command Palette
    • Confirmed Open in Terminal is displayed when right clicking folders in the sidebar and home page widgets
    • Confirmed Open in Terminal is displayed when right clicking an empty space
    • Confirmed Open in Terminal is displayed when right clicking a folder (and multiple folders)
    • Confirmed Open in Terminal is hidden when a file is included in the selection
    • Confirmed the Open in Terminal separator is only displayed when Open in Terminal is displayed
  2. Turned off option to display Open in Terminal and confirmed that:
    • Open in Terminal is displayed in the Command Palette
    • Confirmed Open in Terminal (and the separator) isn't displayed when right clicking in all of the above conditions (sidebar, file area etc).

@yaira2 yaira2 force-pushed the ya/TerminalOption branch from 5fec4cf to a3029f8 Compare July 29, 2025 15:09
@yaira2 yaira2 requested a review from Copilot July 29, 2025 15:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new setting that allows users to hide the "Open in Terminal" option from context menus throughout the Files application while keeping it available in the command palette.

Key changes include:

  • Added a new toggle setting ShowOpenTerminal to the General settings page
  • Updated context menu logic across multiple components to respect this setting
  • Added localization string for the new setting

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
GeneralPage.xaml Adds toggle switch UI for the new "Show option to open folders in Windows Terminal" setting
GeneralViewModel.cs Implements the ShowOpenTerminal property binding for the settings UI
GeneralSettingsService.cs Adds the ShowOpenTerminal setting with default value of true
IGeneralSettingsService.cs Defines the interface contract for the new ShowOpenTerminal property
Resources.resw Adds localization string for the setting display text
ContentPageContextFlyoutFactory.cs Updates context menu logic to respect the ShowOpenTerminal setting
QuickAccessWidgetViewModel.cs Updates widget context menu to conditionally show terminal option
FileTagsWidgetViewModel.cs Updates widget context menu to conditionally show terminal option
DrivesWidgetViewModel.cs Updates widget context menu to conditionally show terminal option
SidebarViewModel.cs Updates sidebar context menu to conditionally show terminal option

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jul 29, 2025
@yaira2 yaira2 merged commit 10de56c into main Jul 29, 2025
9 checks passed
@yaira2 yaira2 deleted the ya/TerminalOption branch July 29, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add option to disable "Open in Windows Terminal" context menu item

3 participants