Skip to content

Code Quality: Fixed Omnibar issues #17408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2025
Merged

Code Quality: Fixed Omnibar issues #17408

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abb9011
Code Quality: Fixed issue where Omnibar would regain focus together w…
yaira2 Aug 7, 2025
7455ff6
Fix `Search' action doesn't work when triggered from the Command Pale…
yaira2 Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Files.App.Controls/Omnibar/Omnibar.Events.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,14 @@ private void AutoSuggestBox_LostFocus(object sender, RoutedEventArgs e)

IsFocused = false;
IsFocusedChanged?.Invoke(this, new(IsFocused));

// Workaround to prevent an issue where if the window loses focus and then regains focus,
// the AutoSuggestBox will regain focus and the suggestions popup will open again.
if (element is TextBox)
{
_previouslyFocusedElement.TryGetTarget(out var previouslyFocusedElement);
previouslyFocusedElement?.Focus(FocusState.Programmatic);
}
}

private async void AutoSuggestBox_KeyDown(object sender, KeyRoutedEventArgs e)
Expand Down
Loading