Skip to content

Fix: Fixed crash when typing quickly in the Filter header#18207

Merged
yair100 merged 1 commit intofiles-community:mainfrom
workbysaran:sg/fix-filter-header-typing-crash
Feb 26, 2026
Merged

Fix: Fixed crash when typing quickly in the Filter header#18207
yair100 merged 1 commit intofiles-community:mainfrom
workbysaran:sg/fix-filter-header-typing-crash

Conversation

@workbysaran
Copy link
Contributor

Resolved / Related Issues
Fixed an intermittent crash possibily caused by rapid keystrokes in the "Filtering for" field. Each keystroke was triggering a full 'FilesAndFolders' collection rebuild on the UI thread with no throttling, overwhelming the WinUI XAML rendering pipeline.

Closes #17804

Steps used to test these changes

  1. Open a folder with many files and enable the Filter header
  2. Type quickly in the "Filtering for" field and verify no crash occurs
  3. Repeat across folders of varying sizes

Copy link
Member

@yair100 yair100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yair100 yair100 added the ready to merge Pull requests that are approved and ready to merge label Feb 26, 2026
@yair100 yair100 merged commit 99d6199 into files-community:main Feb 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Intermittent crash when filtering

2 participants