Skip to content

Fix: Fixed crash when typing quickly in the Filter header #18207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yair100 merged 1 commit into from
Feb 26, 2026
Merged

Fix: Fixed crash when typing quickly in the Filter header #18207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/Files.App/ViewModels/ShellViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ public GitProperties EnabledGitProperties
private CancellationTokenSource watcherCTS;
private CancellationTokenSource searchCTS;
private CancellationTokenSource updateTagGroupCTS;
private CancellationTokenSource? filterDebounceCS;

public event EventHandler FocusFilterHeader;

Expand Down Expand Up @@ -789,7 +790,20 @@ public string? FilesAndFoldersFilter

private void FilesAndFolderFilterUpdated()
{
_ = ApplyFilesAndFoldersChangesAsync();
if (filterDebounceCS is not null)
{
filterDebounceCS.Cancel();
filterDebounceCS.Dispose();
}

filterDebounceCS = new CancellationTokenSource();
var token = filterDebounceCS.Token;

_ = Task.Delay(250, token)
.ContinueWith(_ => ApplyFilesAndFoldersChangesAsync(), token,
TaskContinuationOptions.OnlyOnRanToCompletion,
TaskScheduler.Default)
.Unwrap();
}


Expand Down Expand Up @@ -2796,6 +2810,8 @@ public void UpdateDateDisplay(bool isFormatChange)
public void Dispose()
{
CancelLoadAndClearFiles();
filterDebounceCS?.Cancel();
filterDebounceCS?.Dispose();
App.Logger.LogInformation($"ShellViewModel.Dispose: CurrentFolder={LogPathHelper.GetPathIdentifier(CurrentFolder?.ItemPath)}");

StorageTrashBinService.Watcher.ItemAdded -= RecycleBinItemCreatedAsync;
Expand Down
Loading