Immutable Tuples as C Structs, not pointers #248
+91
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn immutable tuples into C structs, and keep mutable tuples as C pointers.
Collaborator
Author
|
While doing this PR, I have been stomping out other bugs, including stuff from my own codegen tests import numpy as np
import numpy.ctypeslib as ctl
a = np.int64(2)
b = np.int64(1)
s1 = ctl.as_ctypes(a)
s2 = ctl.as_ctypes(b)
print(s1.value, s2.value)
# this prints 1 1 :skull: |
willow-ahrens
requested changes
Dec 1, 2025
Member
willow-ahrens
left a comment
willow-ahrens
left a comment
There was a problem hiding this comment.
Looks good, I would only ask for an ImmutableFType class-based interface.
Even though literally everything should be immutable right now
mtsokol
reviewed
Dec 2, 2025
src/finchlite/codegen/c.py
Outdated
|
|
||
| def scalar_to_ctypes_copy(fmt, obj): | ||
| """ | ||
| This hack is required because it turns out that scalars don't own memory or smth |
src/finchlite/codegen/c.py
Outdated
|
|
||
| import numpy as np | ||
|
|
||
| from finchlite.finch_assembly.struct import MutableStructFType |
Member
There was a problem hiding this comment.
Nitpick: Let's use one convention, with relative import as below.
| np.generic, | ||
| "serialize_to_c", | ||
| "__attr__", | ||
| lambda fmt, obj: np.ctypeslib.as_ctypes(obj), |
Member
There was a problem hiding this comment.
Can we have it as np.ctypeslib.as_ctypes(np.array(obj)), instead? It looks that 0-d arrays print your example correctly. Then we shouldn't need scalar_to_ctypes_copy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn immutable tuples into C structs, and keep mutable tuples as C pointers.