This PR is in order to resolve: [TB] Copying a theme no longer works #1124 #1125
This PR is in order to resolve: [TB] Copying a theme no longer works #1124 #1125
Conversation
✅ Deploy Preview for glistening-gecko-6b417a ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @omesh-omg! Thank you for your PR! Sorry that it took so long to reply. I was on vacation two weeks ag and last week I tried to verify how this change affects the linting and I noticed that our linting needed to be migrated from v8 to v9. When I did the migration linting stopped working. Hopfully will get some time this week to figure that out. But definitely appreciate your PR! |
aaronreed708
left a comment
aaronreed708
left a comment
There was a problem hiding this comment.
Approved with suggested change. Thanks for your contribution!
| //const ds = await themeBuilder.getDesignSystem(name); | ||
| //const nds = await ds.copy(dest); | ||
| const ds = await themeBuilder.getDesignSystem(name); | ||
| const nds = await ds.copy(dest); |
There was a problem hiding this comment.
Could you drop assigning the result to nds since it looks like copy just blindly returns the new design system. Or maybe better, add something like:
if (!nds) {
console.log("failed to copy design system: ", name);
}
in case the copy logic ever changes. Just trying to avoid re-introducing the lint warning since I believe that was the whole point in the original change.
2 participants
it think it was turned into comment because of lint changes we did last year in july
@aaronreed708
you may highlight if I am wrong and it was done intentionally may be ?
re deploying commented code
resolving issue #1124