Skip to content

This PR is in order to resolve: [TB] Copying a theme no longer works #1124 #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omesh-omg wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

This PR is in order to resolve: [TB] Copying a theme no longer works #1124 #1125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions code/src/ui/src/components/SystemCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,8 @@ export const SystemCard: React.FC<Props> = ({
console.log('Design system already exists');
} else {
if (themeBuilder) {
//const ds = await themeBuilder.getDesignSystem(name);
//const nds = await ds.copy(dest);
const ds = await themeBuilder.getDesignSystem(name);
const nds = await ds.copy(dest);
Copy link
Contributor

@aaronreed708 aaronreed708 Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you drop assigning the result to nds since it looks like copy just blindly returns the new design system. Or maybe better, add something like:

if (!nds) {
    console.log("failed to copy design system: ", name);
}

in case the copy logic ever changes. Just trying to avoid re-introducing the lint warning since I believe that was the whole point in the original change.

}
setTimeout(function () {
refresh();
Expand Down