Skip to content

fix(xml): handle empty node with fields #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fioncat merged 1 commit into from
Jan 27, 2026
+6 −0
Merged

fix(xml): handle empty node with fields #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/parse/xml.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,12 @@ fn read<R: BufRead>(reader: &mut Reader<R>, depth: u64) -> Result<Value> {
})
.collect::<Result<_>>()?;

if child.is_null() && !attrs.is_empty() {
// Handle empty node with fields
// Like: <node field1="value1" field2="value2"/>
child = Value::Object(Map::new());
}

// If the child is already an object, that's where attributes should end up in
if child.is_object() {
// We want to have them at the start though, while still being listed
Expand Down