Skip to content

dataconnect: modernize SerializationTestData.kt to use Arb instead of bespoke random data generation #6339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 3, 2024
Merged

dataconnect: modernize SerializationTestData.kt to use Arb instead of bespoke random data generation #6339

merged 11 commits into from
Oct 3, 2024

Conversation

@dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Oct 2, 2024

No description provided.

dconeybe added 11 commits October 1, 2024 16:42
@dconeybe dconeybe self-assigned this Oct 2, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024 •
edited
Loading

Unit Test Results

  1 035 files  +     987    1 035 suites  +987   37m 23s ⏱️ + 35m 54s
  5 805 tests +  5 327    5 782 ✔️ +  5 305  22 💤 +21  1 ❌ +1 
11 883 runs  +10 927  11 838 ✔️ +10 884  44 💤 +42  1 ❌ +1 

For more details on these failures, see this check.

Results for commit b2acdc6. ± Comparison against base commit 2d3e414.

♻️ This comment has been updated with latest results.

@dconeybe dconeybe merged commit 48aab50 into main Oct 3, 2024
264 of 265 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/TestModernization3 branch October 3, 2024 00:17
@firebase firebase locked and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aashishpatil-g aashishpatil-g aashishpatil-g approved these changes

@maneesht maneesht Awaiting requested review from maneesht

@cherylEnkidu cherylEnkidu Awaiting requested review from cherylEnkidu

Assignees

@dconeybe dconeybe

Labels

api: dataconnect main-merge-ack no-changelog size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dconeybe @aashishpatil-g @google-oss-bot