Skip to content

dataconnect: modernize SerializationTestData.kt to use Arb instead of bespoke random data generation #6339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 3, 2024
Merged

dataconnect: modernize SerializationTestData.kt to use Arb instead of bespoke random data generation #6339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
84e51a1
TimestampSerializerUnitTest.kt modernized
dconeybe Oct 1, 2024
ec5f721
ProtoStructEncoderUnitTest.kt modernized
dconeybe Oct 1, 2024
39d683c
ProtoStructDecoderUnitTest.kt modernized
dconeybe Oct 1, 2024
712db3a
ProtoStructEncoderUnitTest.kt: use arb
dconeybe Oct 2, 2024
7c1c1ee
ProtoStructDecoderUnitTest.kt: assertThrows -> shouldThrow
dconeybe Oct 2, 2024
cb4a27b
SerializationTestData.kt: re-written to use Arb
dconeybe Oct 2, 2024
fc9c1dd
ProtoStructDecoderUnitTest.kt fixed to use the new Arb-based API in S…
dconeybe Oct 2, 2024
e60ec58
SerializationTestData.kt: fix NoSuchElementException: Collection is e…
dconeybe Oct 2, 2024
15259bd
SerializationTestData.kt: add back missing comma that adds noise to t…
dconeybe Oct 2, 2024
7587b84
SerializationTestData.kt: expand star imports
dconeybe Oct 2, 2024
b2acdc6
Merge remote-tracking branch 'origin/main' into TestModernization3
dconeybe Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions ...dataconnect/src/test/kotlin/com/google/firebase/dataconnect/ProtoStructDecoderUnitTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
*/
package com.google.firebase.dataconnect

import com.google.firebase.dataconnect.SerializationTestData.serializationTestDataAllTypes
import com.google.firebase.dataconnect.SerializationTestData.withEmptyListOfUnitRecursive
import com.google.firebase.dataconnect.testutil.shouldContainWithNonAbuttingTextIgnoringCase
import com.google.firebase.dataconnect.util.ProtoUtil.buildStructProto
import com.google.firebase.dataconnect.util.ProtoUtil.decodeFromStruct
Expand All @@ -31,9 +33,9 @@ import io.kotest.property.arbitrary.arbitrary
import io.kotest.property.arbitrary.boolean
import io.kotest.property.arbitrary.constant
import io.kotest.property.arbitrary.double
import io.kotest.property.arbitrary.filter
import io.kotest.property.arbitrary.int
import io.kotest.property.arbitrary.list
import io.kotest.property.arbitrary.map
import io.kotest.property.arbitrary.orNull
import io.kotest.property.arbitrary.string
import io.kotest.property.checkAll
Expand All @@ -47,17 +49,21 @@ class ProtoStructDecoderUnitTest {

@Test
fun `decodeFromStruct() can encode and decode complex objects`() = runTest {
val seeds = Arb.string().filter { it.hashCode() != 0 }
checkAll(iterations = 20, seeds) { seed ->
val obj = SerializationTestData.AllTheTypes.newInstance(seed).withEmptyUnitLists()
// TODO(b/370992204) Remove the call to withEmptyListOfUnitRecursive() once the bug that a list
// of Unit is incorrectly decoded as an empty list is fixed.
val arb = Arb.serializationTestDataAllTypes().map { it.withEmptyListOfUnitRecursive() }
checkAll(iterations = 20, arb) { obj ->
val struct = encodeToStruct(obj)
val decodedObj = decodeFromStruct<SerializationTestData.AllTheTypes>(struct)
decodedObj shouldBe obj
}
}

@Ignore(
"b/370992204: Re-enable this test once the bug that a list of Unit is incorrectly " +
"decoded as an empty list is fixed"
)
@Test
@Ignore("A List<Unit> gets decoded as an empty list; if anyone cares, fix it.")
fun `decodeFromStruct() can encode and decode a list of non-nullable Unit`() = runTest {
@Serializable data class TestData(val list: List<Unit>)
checkAll(Arb.list(Arb.constant(Unit))) { list ->
Expand Down
Loading
Loading