Passkey swift tests #12663
Passkey swift tests #12663
Conversation
Generated by 🚫 Danger |
There was a problem hiding this comment.
Reviewed by looking at the Public header changes in main...passkey
| } | ||
| #endif | ||
| if #available(iOS 15.0, macOS 12.0, tvOS 16.0, *) { | ||
| auth.startPasskeySignIn { result, error in |
There was a problem hiding this comment.
Please add finalizePasskeySignIn as well here and below.
There was a problem hiding this comment.
the data type of input for finalizePasskeySignIn is ASAuthorizationPlatformPublicKeyCredentialAssertion which I did not find an initializer. Can you suggest? finalizePasskeyEnrollment is a similar story.
How this is passed to us/customers is thru a platform delegation. How did we test this with Obj-c is to mock the class and to mock the behavior when trying to access the property of the instance.
There was a problem hiding this comment.
You could pass in the ASAuthorizationPlatformPublicKeyCredentialAssertion as a parameter to the test function, since this is a build-only test.
There was a problem hiding this comment.
Thank you Paul. I used the with NSCoder instead, please take a look.
| #endif | ||
| if #available(iOS 15.0, macOS 12.0, tvOS 16.0, *) { | ||
| user.startPasskeyEnrollment(with: "token") { _, _ in | ||
| } |
There was a problem hiding this comment.
finalize variation as well for the User API.
3 participants
Available swift test cases for passkey