Skip to content

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Sep 24, 2024

#13634 addressed the warning so we should be able to go back to building with -warnings-as-errors.

Fix #13704

#no-changelog

@ncooke3 ncooke3 marked this pull request as ready for review September 24, 2024 17:47
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

LGTM on green

@ncooke3
Copy link
Member Author

ncooke3 commented Sep 24, 2024

CocoaPods CI is green so I'll merge.

@ncooke3 ncooke3 merged commit 3d61c54 into main Sep 24, 2024
52 of 53 checks passed
@ncooke3 ncooke3 deleted the nc/fix-13704 branch September 24, 2024 19:46
@firebase firebase locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restore CI warnings-as-errors for FirebaseAuth pod tests with Xcode 16

3 participants