Skip to content

[Infra] Switch back to building Auth with -warnings-as-errors #13713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2024
Merged

[Infra] Switch back to building Auth with -warnings-as-errors #13713

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8e468c
[Infra] Switch back to building Auth with -warnings-as-errors
ncooke3 Sep 24, 2024
ae7404a
Fix warning
ncooke3 Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions FirebaseAuth.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,11 @@ supports email and password accounts, as well as several 3rd party authenticatio
'FirebaseAuth/README.md',
'FirebaseAuth/CHANGELOG.md'
]
# TODO(#13704) Restore warnings-as-errors checking.
# 'OTHER_SWIFT_FLAGS' => "$(inherited) #{ENV.key?('FIREBASE_CI') ? '-D FIREBASE_CI -warnings-as-errors' : ''}"
s.pod_target_xcconfig = {
'GCC_C_LANGUAGE_STANDARD' => 'c99',
# The second path is to find FirebaseAuth-Swift.h from a pod gen project
'HEADER_SEARCH_PATHS' => '"${PODS_TARGET_SRCROOT}" "${OBJECT_FILE_DIR_normal}/${NATIVE_ARCH_ACTUAL}"',
'OTHER_SWIFT_FLAGS' => "$(inherited) #{ENV.key?('FIREBASE_CI') ? '-D FIREBASE_CI' : ''}"
'OTHER_SWIFT_FLAGS' => "$(inherited) #{ENV.key?('FIREBASE_CI') ? '-D FIREBASE_CI -warnings-as-errors' : ''}"
}
s.framework = 'Security'
s.ios.framework = 'SafariServices'
Expand Down
Loading