[Vertex AI] Replace sample CustomStringConvertible extensions
#13845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncooke3
approved these changes
Oct 8, 2024
paulb777
approved these changes
Oct 8, 2024
MojtabaHs
pushed a commit
to MojtabaHs/firebase-ios-sdk
that referenced
this pull request
Oct 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the
CustomStringConvertibleextensions onHarmCategoryandHarmProbabilityin the sample app with customdisplayValueproperties. This fixes the warningExtension declares a conformance of imported type 'HarmCategory' to imported protocol 'CustomStringConvertible'; this will not behave correctly if the owners of 'FirebaseVertexAI' introduce this conformance in the future.As the warning describes, this also allows us to customize the
descriptionin the SDK by conforming toCustomStringConvertiblefor those types.#no-changelog