Skip to content

[Vertex AI] Replace sample CustomStringConvertible extensions #13845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2024
Merged

[Vertex AI] Replace sample CustomStringConvertible extensions #13845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions FirebaseVertexAI/Sample/ChatSample/Views/ErrorDetailsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@ import FirebaseVertexAI
import MarkdownUI
import SwiftUI

extension HarmCategory: CustomStringConvertible {
public var description: String {
private extension HarmCategory {
/// Returns a description of the `HarmCategory` suitable for displaying in the UI.
var displayValue: String {
switch self {
case .dangerousContent: "Dangerous content"
case .harassment: "Harassment"
Expand All @@ -28,8 +29,9 @@ extension HarmCategory: CustomStringConvertible {
}
}

extension SafetyRating.HarmProbability: CustomStringConvertible {
public var description: String {
private extension SafetyRating.HarmProbability {
/// Returns a description of the `HarmProbability` suitable for displaying in the UI.
var displayValue: String {
switch self {
case .high: "High"
case .low: "Low"
Expand Down Expand Up @@ -73,10 +75,9 @@ private struct SafetyRatingsSection: View {
Section("Safety ratings") {
List(ratings, id: \.self) { rating in
HStack {
Text("\(String(describing: rating.category))")
.font(.subheadline)
Text(rating.category.displayValue).font(.subheadline)
Spacer()
Text("\(String(describing: rating.probability))")
Text(rating.probability.displayValue)
}
}
}
Expand Down
Loading