Streamable functions - Continuation of #14395 #14465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two tests to cover new API Add enum to handle response from stream Add extension to Callable for Streamable Content.
Add Enum to switch over response type Add New test to match new API design doc.
Add TODO note.
ncooke3
reviewed
Feb 18, 2025
ncooke3
reviewed
Feb 18, 2025
ncooke3
reviewed
Feb 18, 2025
| let callable: Callable<String, StreamResponse<String, String>> = functions.httpsCallable("genStream") | ||
| let stream = callable.stream("genStream") | ||
| //Todo fetch actual content. | ||
| for try await response in stream { |
There was a problem hiding this comment.
@eBlender, w.r.t. your comment about it not parsing it, is the issue that this is throwing a parsing error?
There was a problem hiding this comment.
Yes, this is the part where we don't get a proper response.
Tried with another approach like the examples above and the genStream flow will work, but it seem that StreamRepsone<> is not it's cup of tea :(
Any other type that will do fine, <T, T> as examples above.
Callable<[Location], WeatherForecast> = functions.httpsCallable("genStreamWeather")
Accepted suggestion. Co-authored-by: Nick Cooke <[email protected]>
Accepted suggestion. Co-authored-by: Nick Cooke <[email protected]>
Accepted suggestion Co-authored-by: Nick Cooke <[email protected]>
Add placeholders so we can pass CI, while we finalize stream() functionality
ncooke3
merged commit caeff20
into
firebase:streamable-functions
37 of 38 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in a feature request so that we
can discuss it together.