-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Streamable functions - Continuation of #14395 #14465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ncooke3
merged 7 commits into
firebase:streamable-functions
from
eBlender:streamable-functions
Feb 19, 2025
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7370352
Add tests to cover new API
eBlender 5d36f3e
Update Tests
eBlender 7f1d359
Update IntegrationTests.swift
eBlender 1e4e0dc
Update FirebaseFunctions/Sources/Callable+Codable.swift
eBlender 1e769cc
Update FirebaseFunctions/Tests/Integration/IntegrationTests.swift
eBlender 05700ea
Update FirebaseFunctions/Sources/Callable+Codable.swift
eBlender b28c712
Update for CI
eBlender File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eBlender, w.r.t. your comment about it not parsing it, is the issue that this is throwing a parsing error?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is the part where we don't get a proper response.
Tried with another approach like the examples above and the genStream flow will work, but it seem that StreamRepsone<> is not it's cup of tea :(
Any other type that will do fine, <T, T> as examples above.
Callable<[Location], WeatherForecast> = functions.httpsCallable("genStreamWeather")