Skip to content

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Aug 14, 2025

Updated all macos-15 jobs to use Xcode 16.4 instead of 16.2 since the platforms/simulators are now only included in Xcode 16.3, 16.4 and 26 Beta. The alternative would be to install the platforms with, e.g., xcodebuild -downloadPlatform iOS to continue using 16.2 on macOS 15.

Platform tools (SDK and simulator runtimes) will only be available for the three most recently installed versions of Xcode, including beta and pre-release versions for macOS-15-based and later images.
-- actions/runner-images#12541

Note: This does not affect the macos-14 runner images and they have been kept at 16.2.

#no-changelog

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@ncooke3
Copy link
Member

ncooke3 commented Aug 15, 2025

I can help here. I'll start by taking a look at core spm ones.

Co-authored-by: Nick Cooke <[email protected]>
@ncooke3
Copy link
Member

ncooke3 commented Aug 15, 2025

Some unrecognized destinations may be fixed by #15206. Will need to see what happens in practice.

ncooke3 and others added 5 commits August 15, 2025 17:27
  The Firestore CI has been failing with an error that suggests Xcode is confused about which iPhone 16 simulator to use.

  This commit attempts to resolve the issue by explicitly selecting Xcode 16.4 before the build step. It's not guaranteed that this will solve the
  problem, but it's a likely candidate for the root cause.
  The xcbeautify tool, while useful for cleaning up xcodebuild output, can truncate long or multi-line error messages. This is particularly problematic
  for configuration errors that occur early in the build process, making it difficult to diagnose the root cause from the GitHub Actions logs alone.

  This change adds a step to the xcodebuild job in the Firestore workflow to upload the raw xcodebuild-*.log file as a build artifact whenever a failure
  occurs. This ensures that the full, untruncated log is always available for download and inspection, facilitating more effective debugging.
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving if you want to land incremental improvements for nightlies ...

@ncooke3 ncooke3 marked this pull request as ready for review August 18, 2025 01:39
@ncooke3
Copy link
Member

ncooke3 commented Aug 18, 2025

Thank you, @paulb777!

@ncooke3 ncooke3 merged commit 69ad8a4 into main Aug 18, 2025
493 of 502 checks passed
@ncooke3 ncooke3 deleted the ah/ci-macos15-xcode16.4 branch August 18, 2025 01:40
@andrewheard
Copy link
Contributor Author

Thanks, @ncooke3 and @paulb777 !

@firebase firebase locked and limited conversation to collaborators Sep 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants