-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[CI] Run all macos-15
jobs with Xcode 16.4
#15200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
I can help here. I'll start by taking a look at core spm ones. |
Co-authored-by: Nick Cooke <[email protected]>
Some unrecognized destinations may be fixed by #15206. Will need to see what happens in practice. |
The Firestore CI has been failing with an error that suggests Xcode is confused about which iPhone 16 simulator to use. This commit attempts to resolve the issue by explicitly selecting Xcode 16.4 before the build step. It's not guaranteed that this will solve the problem, but it's a likely candidate for the root cause.
The xcbeautify tool, while useful for cleaning up xcodebuild output, can truncate long or multi-line error messages. This is particularly problematic for configuration errors that occur early in the build process, making it difficult to diagnose the root cause from the GitHub Actions logs alone. This change adds a step to the xcodebuild job in the Firestore workflow to upload the raw xcodebuild-*.log file as a build artifact whenever a failure occurs. This ensures that the full, untruncated log is always available for download and inspection, facilitating more effective debugging.
This reverts commit 07a8afc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving if you want to land incremental improvements for nightlies ...
Thank you, @paulb777! |
Updated all
macos-15
jobs to use Xcode 16.4 instead of 16.2 since the platforms/simulators are now only included in Xcode 16.3, 16.4 and 26 Beta. The alternative would be to install the platforms with, e.g.,xcodebuild -downloadPlatform iOS
to continue using 16.2 on macOS 15.Note: This does not affect the
macos-14
runner images and they have been kept at 16.2.#no-changelog