-
Notifications
You must be signed in to change notification settings - Fork 1.7k
infra: Migrate away from ObjC quickstarts #15478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+815
−424
Merged
Changes from 10 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
9038ada
feat(infra): Add script to set up SPM-based quickstarts (#15338)
ncooke3 8a9676e
chore(ci): Update dependency on WIP QS branch
ncooke3 9569aa4
refactor: Remove is_legacy QS testing flags (#15353)
ncooke3 5349b87
fix: zip qs testing workflows (#15358)
ncooke3 f7a8628
fix(ci): Resolve syntax error in zip.yml (#15425)
ncooke3 ca0ae6b
fix: Fixes to artifact uploads and scheme name-related issues (#15437)
ncooke3 9c40066
chore: Remove duplicate action/checkout invocations (#15450)
ncooke3 eb1d249
chore: Remove outdated TODO (#15451)
ncooke3 883da48
Merge branch 'main' into nc/quickstarts
ncooke3 26536b9
chore: Revert debugging code in nc/quickstarts branch (#15479)
ncooke3 ea22b5b
fix: commit fetching bug in scripts/update_firebase_spm_dependency.sh
ncooke3 bc38218
fix: Remove test action for prerelease x fiam job
ncooke3 02f1552
Apply suggestions from code review
ncooke3 c8517c4
Apply suggestion from @gemini-code-assist[bot]
ncooke3 aeb934d
Merge branch 'main' into nc/quickstarts
ncooke3 9490884
Apply suggestions from code review
ncooke3 ce73bed
Merge branch 'main' into nc/quickstarts
ncooke3 55f340a
Apply suggestion from @ncooke3
ncooke3 3113261
Apply suggestion from @ncooke3
ncooke3 b2ae0f1
Apply suggestion from @ncooke3
ncooke3 557490f
upload
ncooke3 eeeb0ac
Merge branch 'main' into nc/quickstarts
ncooke3 6a1b0c9
Update .github/workflows/release_cocoapods.yml
ncooke3 905ea7d
Update .github/workflows/zip.yml
ncooke3 f329794
fix: messaging zip failure (#15502)
ncooke3 dac5399
fix: ai GHA needs clause inconsistency
ncooke3 fe91706
fix: ai qs in zip test (#15503)
ncooke3 2f20abe
reverts
ncooke3 2888440
Update scripts/remove_data.sh
ncooke3 699aa88
Update .github/workflows/release.yml
ncooke3 dd5e7ff
Update scripts/setup_quickstart_framework.sh
ncooke3 6e1b8de
Update Gemfile
ncooke3 f8e50eb
finishing touches
ncooke3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,10 +45,9 @@ jobs: | |
| uses: ./.github/workflows/common_quickstart.yml | ||
| with: | ||
| product: ABTesting | ||
| is_legacy: true | ||
| setup_command: scripts/setup_quickstart.sh abtesting | ||
| plist_src_path: scripts/gha-encrypted/qs-database.plist.gpg | ||
| plist_dst_path: quickstart-ios/database/GoogleService-Info.plist | ||
| setup_command: scripts/setup_quickstart_spm.sh abtesting | ||
| plist_src_path: scripts/gha-encrypted/qs-abtesting.plist.gpg | ||
| plist_dst_path: quickstart-ios/abtesting/GoogleService-Info.plist | ||
| secrets: | ||
| plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} | ||
|
|
||
|
|
@@ -66,17 +65,13 @@ jobs: | |
| with: | ||
| python-version: '3.11' | ||
| - name: Setup quickstart | ||
| env: | ||
| LEGACY: true | ||
| run: scripts/setup_quickstart.sh abtesting | ||
| - name: Install Secret GoogleService-Info.plist | ||
| run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-abtesting.plist.gpg \ | ||
| quickstart-ios/abtesting/GoogleService-Info.plist "$plist_secret" | ||
| - name: Xcode | ||
| run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer | ||
| - name: Build swift quickstart | ||
| env: | ||
| LEGACY: true | ||
| run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh ABTesting) | ||
| - id: ftl_test | ||
| uses: FirebaseExtended/github-actions/[email protected] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,14 +47,7 @@ jobs: | |
| uses: ./.github/workflows/common_quickstart.yml | ||
| with: | ||
| product: Crashlytics | ||
| is_legacy: true | ||
| quickstart_type: swift | ||
| setup_command: | | ||
| scripts/setup_quickstart.sh crashlytics | ||
| mkdir quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Pods/FirebaseCrashlytics | ||
| # Set the deployed pod location of run and upload-symbols with the development pod version. | ||
| cp Crashlytics/run quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Pods/FirebaseCrashlytics/ | ||
| cp Crashlytics/upload-symbols quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Pods/FirebaseCrashlytics/ | ||
| setup_command: scripts/setup_quickstart_spm.sh crashlytics | ||
| plist_src_path: scripts/gha-encrypted/qs-crashlytics.plist.gpg | ||
| plist_dst_path: quickstart-ios/crashlytics/GoogleService-Info.plist | ||
| secrets: | ||
|
|
@@ -77,20 +70,12 @@ jobs: | |
| run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer | ||
| - name: Setup quickstart | ||
| run: scripts/setup_quickstart.sh crashlytics | ||
| env: | ||
| LEGACY: true | ||
| - name: Install Secret GoogleService-Info.plist | ||
| run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-crashlytics.plist.gpg \ | ||
| quickstart-ios/crashlytics/GoogleService-Info.plist "$plist_secret" | ||
| - name: Build swift quickstart | ||
| run: | | ||
| mkdir quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Pods/FirebaseCrashlytics | ||
| # Set the deployed pod location of run and upload-symbols with the development pod version. | ||
| cp Crashlytics/run quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Pods/FirebaseCrashlytics/ | ||
| cp Crashlytics/upload-symbols quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Pods/FirebaseCrashlytics/ | ||
| ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh Crashlytics swift) | ||
| env: | ||
| LEGACY: true | ||
| - id: ftl_test | ||
| uses: FirebaseExtended/github-actions/[email protected] | ||
| with: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.