-
Notifications
You must be signed in to change notification settings - Fork 1.7k
infra: Migrate away from ObjC quickstarts #15478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
This comment was marked as outdated.
This comment was marked as outdated.
f3e7558 to
eb1d249
Compare
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a significant infrastructure update to migrate away from Objective-C quickstarts. It introduces several new scripts (patch_crashlytics_run_path.rb, remove_spm_dependencies.rb, setup_quickstart_spm.sh) to handle Xcode project modifications and SPM setup in a more automated and robust way. Existing scripts are also improved with better error handling, robustness, and simplification. The changes are well-structured and greatly improve the CI process for testing quickstarts. I have a couple of minor suggestions to further improve the new scripts' reusability and consistency.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Corresponds to quickstart-ios/pull/1806
Follow-up work
Fixes #8057
#no-changelog